Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a new HttpClient on every request #2

Open
whitfin opened this issue Oct 1, 2017 · 1 comment
Open

Avoid creating a new HttpClient on every request #2

whitfin opened this issue Oct 1, 2017 · 1 comment

Comments

@whitfin
Copy link
Contributor

whitfin commented Oct 1, 2017

Seems unnecessary to keep creating one, as we can just keep the client instance in the main GroupsIOApiClient and allow it to be closed. I'll gladly contribute this back if you're willing to accept the changes :)

@nightowlengineer
Copy link
Owner

Yep, happy for any/all PRs on this project. Haven't had much time recently to finish the new/updated calls off, and so other things like a proper review of things like that haven't taken place yet. If you're happy to do the work that would be great :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants