Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use better naming convention #17

Open
busterbeam opened this issue Jul 13, 2021 · 2 comments
Open

Please use better naming convention #17

busterbeam opened this issue Jul 13, 2021 · 2 comments

Comments

@busterbeam
Copy link

for i, length in enumerate(lengths):
print("Querying {}".format(videos[i]))
i += 1
s = sum(lengths[:i-1])
e = sum(lengths[:i])
# query consists of one episode
query = vectors[s:e]
# rest of the feature vectors

What does s and e mean in your script?? Please use better naming convention

@pierre-andre-long
Copy link

They mean respectively "start frame number" and "end frame number".

@nielstenboom
Copy link
Owner

@pierre-andre-long is totally right! :)

Agree that some variable naming could be better though, they're artifacts from converting a large jupyter notebook with scientific code to this python module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants