From 9be11f5435f64fe9575b4113dc62ec7b9b4334af Mon Sep 17 00:00:00 2001 From: PApostol <50751110+PApostol@users.noreply.github.com> Date: Mon, 21 Mar 2022 16:01:57 +0000 Subject: [PATCH] Various docstring fixes (#18221) --- superset/utils/mock_data.py | 3 ++- superset/views/utils.py | 1 + tests/integration_tests/fixtures/query_context.py | 2 -- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/utils/mock_data.py b/superset/utils/mock_data.py index e51bb39e20ff2..1c6515804b7fa 100644 --- a/superset/utils/mock_data.py +++ b/superset/utils/mock_data.py @@ -176,7 +176,7 @@ def add_data( If the table already exists `columns` can be `None`. :param Optional[List[ColumnInfo]] columns: list of column names and types to create - :param int run_nows: how many rows to generate and insert + :param int num_rows: how many rows to generate and insert :param str table_name: name of table, will be created if it doesn't exist :param bool append: if the table already exists, append data or replace? """ @@ -239,6 +239,7 @@ def add_sample_rows( ) -> Iterator[Model]: """ Add entities of a given model. + :param Session session: an SQLAlchemy session :param Model model: a Superset/FAB model :param int count: how many entities to generate and insert """ diff --git a/superset/views/utils.py b/superset/views/utils.py index 62639174f647e..19c9a2eaf05af 100644 --- a/superset/views/utils.py +++ b/superset/views/utils.py @@ -279,6 +279,7 @@ def apply_display_max_row_limit( metadata. :param sql_results: The results of a sql query from sql_lab.get_sql_results + :param rows: The number of rows to apply a limit to :returns: The mutated sql_results structure """ diff --git a/tests/integration_tests/fixtures/query_context.py b/tests/integration_tests/fixtures/query_context.py index e8a3118bf5db0..00a3036e01c25 100644 --- a/tests/integration_tests/fixtures/query_context.py +++ b/tests/integration_tests/fixtures/query_context.py @@ -37,8 +37,6 @@ def get_query_context( generated by the "Boy Name Cloud" chart in the examples. :param query_name: name of an example query, which is always in the format of `datasource_name[:test_case_name]`, where `:test_case_name` is optional. - :param datasource_id: id of datasource to query. - :param datasource_type: type of datasource to query. :param add_postprocessing_operations: Add post-processing operations to QueryObject :param add_time_offsets: Add time offsets to QueryObject(advanced analytics) :param form_data: chart metadata