Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual naming override of SpotArea and CustomArea switch #83

Closed
dresken opened this issue Feb 8, 2022 · 3 comments
Closed

Allow manual naming override of SpotArea and CustomArea switch #83

dresken opened this issue Feb 8, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dresken
Copy link

dresken commented Feb 8, 2022

Feature Request: Instead of the automatic labelling (eg "SpotArea 4 Deebot") allow a name to be specified for a switch.

As I rename these in Home afterward to something more useful, but then I lose what number is actually what switch if they need any updates.

Cheers

@nicoduj
Copy link
Owner

nicoduj commented Feb 19, 2022

Hi,

I did not implement this since most users are relying on home feature to rename switches, and moreover I can't prevent that. I understand however what you mean, so I am putting this in the backlog.

@nicoduj nicoduj self-assigned this Feb 19, 2022
@nicoduj nicoduj added the enhancement New feature or request label Feb 19, 2022
@nicoduj
Copy link
Owner

nicoduj commented Feb 19, 2022

1.4.8-beta.1 , but could not test it since I have no deebot with spot / custom area feature.

@dresken
Copy link
Author

dresken commented Feb 20, 2022

Thank you so much.

Just nothing for others that it didn't like adding a name to existing config and showed the below error - I've removed the cached accessory and it now seems fine.

Error: Cannot add a Service with the same UUID 'XXXXXXXX-XXXX-XXXX-XXXXX-XXXXXXXXXXX' and subtype 'SwitchSpotAreaService0Deebot' as another Service in this Accessory.
at Accessory.addService (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:473:17)
at PlatformAccessory.addService (/usr/local/lib/node_modules/homebridge/src/platformAccessory.ts:93:41)
at myDeebotEcovacsPlatform.loadDeebots (/usr/local/lib/node_modules/homebridge-deebotecovacs/index.js:500:27)
at DeebotEcovacsAPI. (/usr/local/lib/node_modules/homebridge-deebotecovacs/index.js:193:31)
at DeebotEcovacsAPI.emit (node:events:390:28)
at /usr/local/lib/node_modules/homebridge-deebotecovacs/deebotEcovacsAPI.js:62:16
at processTicksAndRejections (node:internal/process/task_queues:96:5)

@nicoduj nicoduj added this to the 1.4.8 milestone Apr 10, 2022
@nicoduj nicoduj closed this as completed Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants