Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable scrolling for targets in a different container #20

Closed
misaizdaleka opened this issue Jul 27, 2017 · 2 comments
Closed

Comments

@misaizdaleka
Copy link

Hi,
So in one div I have my anchors which I click for scrolling and in another one are the targets to scroll to.
This usecase is not working. Here's a plunkr for you to see:
https://plnkr.co/edit/y345JeEKeOz4pv9maZaV?p=preview

Am I setting something wrong, or is it not possble?

Thanks

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Angular version: 4

@nicky-lenaers
Copy link
Owner

Hi @misaizdaleka , thank you for your issue. As of this moment, setting a custom scroll container is not possible. You're usecase seems a valid one to enable this feature. In short, these are the requirements for this feature:

  • A new directive, something like [ngx-scroll-to-container]
  • A check whether the container is scrollable
  • Some tests to verify the behaviour

You're welcome to give it a go, otherwise I'll be developing this feature as soon as I can.

@nicky-lenaers nicky-lenaers changed the title Scrolling doesn't work when targets are in a different container Feature: Enable scrolling for targets in a different container Jul 27, 2017
@nicky-lenaers
Copy link
Owner

@misaizdaleka I'm happy to announce that this feature has been merged in the current stable release 0.4.0. Please see the CHANGELOG for more details and check out the fresh release at NPM.

Thanks again for your issue reporting! Hopefully this module will serve you well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants