Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): support for angular v13 #164

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

Jonnyprof
Copy link
Contributor

refactor: replace tslint with eslint
refactor: change protractor to cypress
build: update third party libraries

@Jonnyprof Jonnyprof force-pushed the update-angular-13 branch 5 times, most recently from eb8614c to 81a2e5b Compare June 2, 2022 11:10
@igorlino
Copy link

igorlino commented Jun 8, 2022

@nicky-lenaers Could please take this up?

@rafa-suagu
Copy link
Collaborator

@nicky-lenaers Could please take this up?

I will merge this PR and publish the new version ASAP

@HarelM
Copy link

HarelM commented Jun 8, 2022

Thanks @rafa-as!

@igorlino
Copy link

igorlino commented Jun 9, 2022

@Jonnyprof any chance to include angular v14 support?

@nicky-lenaers
Copy link
Owner

Thanks @rafa-as , I am not actively maintaining this package anymore

@andreas-aeschlimann
Copy link
Collaborator

Thanks @rafa-as , I am not actively maintaining this package anymore

Would you mind signing it over? The package is still very popular and useful to many people.

BTW: I wrote you a mail some months ago about it, but haven't received a reply yet.

@nicky-lenaers
Copy link
Owner

@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?

@rafa-suagu
Copy link
Collaborator

We are working to make the v14 version compatible also

@andreas-aeschlimann
Copy link
Collaborator

@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?

Don't worry, it wasn't that important (logs say it was on Mar 23, 23:51).

Thank you for your quick reply. If @rafa-as wants to help, maybe you can add him as well?

The only question that remains is how we are going to publish it. If we want to continue to use the current NPM repository, you would need to give us access there as well (it seems to be simple and possible on a per-repo basis). Otherwise we would need to start a fork.

@rafa-suagu
Copy link
Collaborator

@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?

Don't worry, it wasn't that important (logs say it was on Mar 23, 23:51).

Thank you for your quick reply. If @rafa-as wants to help, maybe you can add him as well?

The only question that remains is how we are going to publish it. If we want to continue to use the current NPM repository, you would need to give us access there as well (it seems to be simple and possible on a per-repo basis). Otherwise we would need to start a fork.

@andreas-aeschlimann I have npm permissions to publish new versions ;)

@andreas-aeschlimann
Copy link
Collaborator

@andreas-aeschlimann Thanks for your reply. I must have overlooked your email (still can't find it though), sorry for that. I added you as a collaborator to this repo. Is this sufficient for you to continue?

Don't worry, it wasn't that important (logs say it was on Mar 23, 23:51).
Thank you for your quick reply. If @rafa-as wants to help, maybe you can add him as well?
The only question that remains is how we are going to publish it. If we want to continue to use the current NPM repository, you would need to give us access there as well (it seems to be simple and possible on a per-repo basis). Otherwise we would need to start a fork.

@andreas-aeschlimann I have npm permissions to publish new versions ;)

Ah, great. I think the most important thing is that we have a release for each Angular version (if necessary). I'll be available if you need support.

@mparpaillon
Copy link

Hey all. Can we merge and publish this to npm? Looks like the PR is ready

@dxs0319
Copy link

dxs0319 commented Jun 27, 2022

Hey all. Can we merge and publish this to npm? Looks like the PR is ready

Yes please! Would greatly appreciate it @rafa-as

@Alessandroinfo
Copy link

@rafa-as When you will merge this PR?

@almoral
Copy link

almoral commented Jul 12, 2022

@rafa-as Is there any timeline for merging this PR? It would be immensely helpful!

@andreas-aeschlimann
Copy link
Collaborator

@rafa-as, is there a specific reason why we are waiting with the update? I would do it, unfortunately I only received permissions for this repo and not for NPM. We should really publish the update, Angular 14 is already out as well.

@nicky-lenaers
Copy link
Owner

@andreas-aeschlimann You now have NPM access to publish versions. This should allow you and all those who are waiting for this PR to move on :)

@TheDelta
Copy link

Whats the holdup now? :)

@TheDelta
Copy link

@andreas-aeschlimann @rafa-as I think many would appreciate an answer ;)

@nicky-lenaers in case of no response, should someone else take over, including going through open issues and clean things up?

@nicky-lenaers
Copy link
Owner

@TheDelta Sure, let me know if you're interested:-)

@rafa-suagu
Copy link
Collaborator

rafa-suagu commented Sep 28, 2022

To @TheDelta and the others, I'm so sorry about the silence, for personal reasons I couldn't resolve this PR and the other issues. We are working to finally merge this PR, publish the version and create a new PR for the v14 version, the last one supporting non-ivy compilations.

Thanks for your patience!

@TheDelta
Copy link

Thanks for the good news! Looking forward to it 🚀 ❤️

@andreas-aeschlimann
Copy link
Collaborator

To @TheDelta and the others, I'm so sorry about the silence, for personal reasons I couldn't resolve this PR and the other issues. We are working to finally merge this PR, publish the version and create a new PR for the v14 version, the last one supporting non-ivy compilations.

Thanks for your patience!

Thanks @rafa-as. Is it just a matter of merging and publishing, or is there still work to do? As I have been added to this repo just recently, I didn't want to go ahead and do it without your feedback. I would happily do it if I got the "clearance" from you guys.

@igabesz igabesz mentioned this pull request Sep 30, 2022
@sambernet sambernet mentioned this pull request Oct 19, 2022
@nicky-lenaers
Copy link
Owner

@andreas-aeschlimann Please go ahead

refactor: replace tslint with eslint

refactor: change protractor to cypress

build: update third party libraries

ci: change circleci config
@rafa-suagu rafa-suagu merged commit a8212ea into nicky-lenaers:master Oct 21, 2022
@rafa-suagu rafa-suagu deleted the update-angular-13 branch October 21, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.