New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scroll-to.service.ts imports from 'rxjs/index' #110

Closed

PavelPikat opened this issue Nov 8, 2018 · 0 comments · Fixed by #115

Assignees

Labels

priority: medium type: refactor

PavelPikat commented Nov 8, 2018

ScrollToService imports entire rxjs when used in lazy-loaded module.
Perhaps is should just import from 'rxjs'

PavelPikat referenced this issue


          refactor: fix linting and e2e tests

2fbaca2

nicky-lenaers self-assigned this

nicky-lenaers added type: refactor priority: medium labels

squelix mentioned this issue

Fix rxjs import #115

Merged

nicky-lenaers closed this as completed in #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment