Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

given/surname_match methods should be case insensitive #10

Closed
damonbrodie opened this issue Dec 4, 2018 · 1 comment
Closed

given/surname_match methods should be case insensitive #10

damonbrodie opened this issue Dec 4, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@damonbrodie
Copy link

given_match and surname_match are currently case sensitive substring searches for their respective fields.

I propose that these should be case insensitive searches. It does not seem reasonable that the user would intend to use the case insensitivity to distinguish be between (for example)

John Smith
and
John SMITH

I propose the case insensitivity because there are essentially to schools of thought on storing names. The "traditional" school of thought says to store all names in uppercase for ease of readability vs. the typical first letter capitalization. This improves the hit rate of the content of the fields rather than its formatting.

Backwards compatibility is not broken, however this would potentially change the expected results.

I will submit the patch to this as well as other changes in a PR

@joeyaurel joeyaurel added the enhancement New feature or request label Dec 11, 2018
@joeyaurel joeyaurel added this to the v1.0.0 milestone Dec 11, 2018
@joeyaurel joeyaurel self-assigned this Dec 11, 2018
@joeyaurel
Copy link
Owner

@nomadyow merged and commented in #11 :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants