From df4a10d94bd073eced9cd5e61e8c401eea0577bc Mon Sep 17 00:00:00 2001 From: Aagash Raaj <123377167+aagash-ni@users.noreply.github.com> Date: Wed, 11 Dec 2024 15:51:19 +0530 Subject: [PATCH 1/4] Add toobar standard height token --- .../src/theme-provider/design-token-comments.ts | 3 ++- .../src/theme-provider/design-token-names.ts | 3 ++- .../nimble-components/src/theme-provider/design-tokens.ts | 4 ++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/nimble-components/src/theme-provider/design-token-comments.ts b/packages/nimble-components/src/theme-provider/design-token-comments.ts index 2cc0739068..08855339e9 100644 --- a/packages/nimble-components/src/theme-provider/design-token-comments.ts +++ b/packages/nimble-components/src/theme-provider/design-token-comments.ts @@ -322,5 +322,6 @@ export const comments: { readonly [key in TokenName]: string } = { 'Background fill color for the editable calendar event grab handle', calendarGridBorderColor: 'Border color for the calendar grid', calendarGroupHeaderBackgroundColor: - 'Background color for the calendar resource group header' + 'Background color for the calendar resource group header', + toolbarHeight: 'Standard height for the toolbar' }; diff --git a/packages/nimble-components/src/theme-provider/design-token-names.ts b/packages/nimble-components/src/theme-provider/design-token-names.ts index 534998f24b..dd16747a95 100644 --- a/packages/nimble-components/src/theme-provider/design-token-names.ts +++ b/packages/nimble-components/src/theme-provider/design-token-names.ts @@ -263,7 +263,8 @@ export const tokenNames: { readonly [key in TokenName]: string } = { calendarEventFillBlockedColor: 'calendar-event-fill-blocked-color', calendarGrabHandleBackgroundColor: 'calendar-grab-handle-background-color', calendarGridBorderColor: 'calendar-grid-border-color', - calendarGroupHeaderBackgroundColor: 'calendar-group-header-background-color' + calendarGroupHeaderBackgroundColor: 'calendar-group-header-background-color', + toolbarHeight: 'toolbar-height' }; const prefix = 'ni-nimble'; diff --git a/packages/nimble-components/src/theme-provider/design-tokens.ts b/packages/nimble-components/src/theme-provider/design-tokens.ts index 8016031c14..b2371bbd29 100644 --- a/packages/nimble-components/src/theme-provider/design-tokens.ts +++ b/packages/nimble-components/src/theme-provider/design-tokens.ts @@ -520,6 +520,10 @@ export const spinnerLargeHeight = DesignToken.create( styleNameFromTokenName(tokenNames.spinnerLargeHeight) ).withDefault('64px'); +export const toolbarHeight = DesignToken.create( + styleNameFromTokenName(tokenNames.toolbarHeight) +).withDefault('40px'); + // The token gets a default value of the table's default height (480px) // but is given a calculated value in the table styles. export const tableFitRowsHeight = DesignToken.create( From 5de8c343909c958d93b62505c73e43ae9e7980fa Mon Sep 17 00:00:00 2001 From: Aagash Raaj <123377167+aagash-ni@users.noreply.github.com> Date: Wed, 11 Dec 2024 15:51:51 +0530 Subject: [PATCH 2/4] Change files --- ...le-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json diff --git a/change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json b/change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json new file mode 100644 index 0000000000..5613655397 --- /dev/null +++ b/change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Add toobar standard height token", + "packageName": "@ni/nimble-components", + "email": "123377167+aagash-ni@users.noreply.github.com", + "dependentChangeType": "patch" +} From 231085cb39de0e3e13b3d8c4ce2ffb5d0fca9e24 Mon Sep 17 00:00:00 2001 From: Aagash Raaj <123377167+aagash-ni@users.noreply.github.com> Date: Wed, 11 Dec 2024 16:17:25 +0530 Subject: [PATCH 3/4] Lint fix --- .../nimble-components/src/theme-provider/design-token-names.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/nimble-components/src/theme-provider/design-token-names.ts b/packages/nimble-components/src/theme-provider/design-token-names.ts index dd16747a95..a3886de2f5 100644 --- a/packages/nimble-components/src/theme-provider/design-token-names.ts +++ b/packages/nimble-components/src/theme-provider/design-token-names.ts @@ -263,7 +263,8 @@ export const tokenNames: { readonly [key in TokenName]: string } = { calendarEventFillBlockedColor: 'calendar-event-fill-blocked-color', calendarGrabHandleBackgroundColor: 'calendar-grab-handle-background-color', calendarGridBorderColor: 'calendar-grid-border-color', - calendarGroupHeaderBackgroundColor: 'calendar-group-header-background-color', + calendarGroupHeaderBackgroundColor: + 'calendar-group-header-background-color', toolbarHeight: 'toolbar-height' }; From 5b12d05d595695d249deca003f8d3da057723330 Mon Sep 17 00:00:00 2001 From: Aagash Raaj <123377167+aagash-ni@users.noreply.github.com> Date: Wed, 11 Dec 2024 17:22:37 +0530 Subject: [PATCH 4/4] Update change type --- ...imble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json b/change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json index 5613655397..d5b8cf4006 100644 --- a/change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json +++ b/change/@ni-nimble-components-a9107da1-a4c4-492b-9842-3d65680f0a8c.json @@ -1,6 +1,6 @@ { - "type": "patch", - "comment": "Add toobar standard height token", + "type": "minor", + "comment": "Add nimble token for toolbar height", "packageName": "@ni/nimble-components", "email": "123377167+aagash-ni@users.noreply.github.com", "dependentChangeType": "patch"