From 1e887bb1fc17401c229d62980e80179d2666e39e Mon Sep 17 00:00:00 2001 From: mollykreis <20542556+mollykreis@users.noreply.github.com> Date: Fri, 10 Nov 2023 14:50:42 -0600 Subject: [PATCH] Remove `height: auto;` from the nimble-table in the Angular example app (#1660) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request ## ๐Ÿคจ Rationale The nimble-table doesn't support being configured with `height: auto`, so this styling should be removed from the example app. With `height: auto`, no rows of the table are rendered in the app. See #1624 ## ๐Ÿ‘ฉโ€๐Ÿ’ป Implementation Remove `height: auto` from the example app's styling. Now the table uses the default height set in the nimble-table's `:host` styling. This is aligned with how the Blazor example app is styled. ## ๐Ÿงช Testing - Verified the rows of the table are now rendered in the Angular example app ## โœ… Checklist - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. --- .../src/app/customapp/customapp.component.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss b/angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss index ab8bbca558..61ba0d5e0f 100644 --- a/angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss +++ b/angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.scss @@ -70,7 +70,6 @@ nimble-drawer { } nimble-table { - height: auto; max-height: 480px; }