Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphical config module does not print opkg operations during dry-run; inconsistent behavior. #46

Open
amstewart opened this issue Nov 18, 2024 · 1 comment · May be fixed by #54
Open

Graphical config module does not print opkg operations during dry-run; inconsistent behavior. #46

amstewart opened this issue Nov 18, 2024 · 1 comment · May be fixed by #54

Comments

@amstewart
Copy link
Collaborator

Most of the Config modules perform opkg_helper operations during --dry-run conditions, and rely on the opkg_helper._dry_run attribute to suppress filesystem changes. Instead, opkg will print the operation and move on.

But the _GraphicalConfig behaves differently, and instead bails out of configure() early, when in dry-run conditions.

The _Graphical Config should behave the same as the other configs, for consistency.

Related: #45
@amstewart amstewart mentioned this issue Nov 18, 2024
Merged
1 task
@texasaggie97
Copy link
Collaborator

Several of the config classes do this so they should all be updated for this.

@texasaggie97 texasaggie97 linked a pull request Jan 10, 2025 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inconsistent handling of --dry-run in different configs. texasaggie97/nilrt-snac
2 participants
@amstewart @texasaggie97