Replace govuk_formbuilder classes with nhsuk ones #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the forms look more consistent with the prototype.
The actual class is .nhsuk-u-visually-hidden, but when we use the `config-brand` option for the GOVUK Form Builder to configure the classes, it ends up inventing a .nhsuk-visually-hidden class. While we could go and monkey patch all the relevant components to use the correct class, it's easier to just add a new CSS rule.
Don't bold the inline labels, remove the size option that doesn't do anything if the legend is hidden, and use a hint instead of a paragraph.
Stimulus relies on the MutationObserver browser API to work. Jest's JSDOM doesn't implement this, so we need to shim it if we want to use Jest to test our Stimulus controllers.
This implements a Stimulus controller shim to enhance `nhsuk-radios` using the custom JS from `nhsuk-frontend`. Because we're using GOVUK Radios HTML but with NHSUK Radios styling, we need to manually add a `nhsuk-radios--conditional` class to the root element. In addition, NHSUK Radios use `aria-controls` on the server-rendered HTML, but GOVUK Radios use `data-aria-controls` and enhance it when JS initialises. Using `data-aria-controls` is the better solution, because it means that the attribute doesn't kick in in a no-JS situation.
misaka
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the forms look more consistent with the prototype.
Bugs:
Before
After