Flushing audit data during BeforeTransactionCompletion is forbidden in some cases since NH 5

[IwanowM]

According to nhibernate-reference

As of NHibernate v5.0, using transaction scope and trying to use the session connection within AfterTransactionCompletion is forbidden and will raise an exception. If the setting transaction.use_connection_on_system_prepare is false, it will forbid any connection usage from BeforeTransactionCompletion event too, when this event is triggered by a transaction scope commit or rollback.

But, as we can see here AuditProcessManager.cs, only one way to flush audit data is inside BeforeTransactionCompletion.
Now it leads to throwing NHibernate.HibernateException Connection usage is currently disallowed

So, it looks like, we have to serve opportunity of flushing audit data on NH session flush.

[RogerKratz]

Can you please attach a failing test?
About your last sentence... Is there a suitable ext point or similar for that in NH Core you mean?

[RogerKratz]

@IwanowM
Dont really follow what the exact problem is. There is some (green) transactionscope tests in envers today.

[RogerKratz]

Close this one, leave corresponding PR #8 open.