Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Type as PropertyPart CustomType instead of only name #347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use Type as PropertyPart CustomType instead of only name #347

wants to merge 2 commits into from

Commits on Jul 4, 2016

  1. Don't use only name for PropertyPart.CustomType 

    - Use the constructor of TypeReference with Type argument instead of the
  constructor with string argument in the overloads of CustomType in
  PropertyPart where an explicit Type is passed.
- This fixes the problem that Fluent NHibernate may map a wrong type
  for a property although an explicit type was passed to CustomType.
  This problem can happen if there are two types with names which only
  differ in upper / lower case. Such similar type names can e.g. be
  caused by obfuscation tools.
    @visubesy
    visubesy authored and besy committed Jul 4, 2016
    Configuration menu
    Copy the full SHA
    d9621a8 View commit details
    Browse the repository at this point in the history

  2. Adapt tests to new behaviour of PropertyPart 

    - The production code of the CustomType overloads of PropertyPart was
  changed to use a different constructor of TypeReference when an
  explicit Type was given. This caused two tests to fail although the
  code still should work correctly.
- Change failing tests to expect the new behaviour.
    @visubesy
    visubesy authored and besy committed Jul 4, 2016
    Configuration menu
    Copy the full SHA
    767aea3 View commit details
    Browse the repository at this point in the history