Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

performance is slow when dealing with large data set #45

Closed
born2net opened this issue Jan 11, 2017 · 1 comment
Closed

performance is slow when dealing with large data set #45

born2net opened this issue Jan 11, 2017 · 1 comment

Comments

@born2net
Copy link

born2net commented Jan 11, 2017

We have a large data set, about 11,000+ records, and we see major slow down in the application when the Redux devtool is enabled.

As soon as we disabled it, all is great and fast again.

// StoreDevtoolsModule.instrumentOnlyWithExtension(),

If this is a challenging fix, I would like to be able to pause / mute the extension and only activate it when I need it. This way we will not have to manually mark and unmark all the time in the source code:

StoreDevtoolsModule.instrumentOnlyWithExtension(),

already set the history to 5.
if any other recommendation on optimization, will be glad to test,

now it could very well be that the bug is really with the chrome extension itself and not the ngrx side of things....

so I did further testing and this is definitely an issue when dealing with a data set of 11,000+ items.
I also want to note that if you click the commit button, things will works just fine for a few more iterations.
So maybe the history of the commit is what is causing the slowness?
Is there a way to simply auto commit after every store update while in development mode?

I created a video of the issue:
https://dl.dropboxusercontent.com/u/93017334/ReduxDev.mp4

Regards,

Sean

@born2net born2net changed the title performance is slow when dealing with very large data set performance is slow when dealing with large data set Jan 11, 2017
@born2net
Copy link
Author

this while not entirely fix it, does make the issue a non issue (requires a lot of effort to make it hang now)
good enough:

StoreDevtoolsModule.instrumentStore({
            maxAge: 2,
        }),

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant