Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Codegen): Add base code and build for @ngrx/codegen #534

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

MikeRyanDev
Copy link
Member

Includes basic implementation for the @ngrx/codegen proposal

@MikeRyanDev MikeRyanDev changed the title feat(Codegen): Add base code and build for @ngrx/codegen WIP: feat(Codegen): Add base code and build for @ngrx/codegen Oct 30, 2017
@bmayen
Copy link

bmayen commented Oct 30, 2017

Why not devkit schematics for this?

@MikeRyanDev
Copy link
Member Author

@bmayen Why would you suggest schematics? Genuinely curious.

@bmayen
Copy link

bmayen commented Oct 30, 2017

Primarily because a) it already exists to handle code generation, and b) would give us a single workflow when using something like Angular CLI.

In the same way that Angular provides a set of schematics which CLI consumes, so could ngrx. Then organizations, which may have customization needs, have an easy way to extend the defaults.

Also, over time, schematics looks like it will become more powerful; supporting user prompting, for instance. Would be nice to be able to leverage this without having to develop and maintain similar functionality in parallel.

@MikeRyanDev MikeRyanDev changed the title WIP: feat(Codegen): Add base code and build for @ngrx/codegen feat(Codegen): Add base code and build for @ngrx/codegen Oct 31, 2017
@MikeRyanDev
Copy link
Member Author

We'll explore how to integrate this tool with Schematics. Merging early to start producing nightly builds.

@bmayen
Copy link

bmayen commented Oct 31, 2017

Sounds good! Let me know if I can help with any Schematics effort.

@brandonroberts brandonroberts merged commit 2a22211 into master Oct 31, 2017
@brandonroberts brandonroberts deleted the feat/codegen-setup branch October 31, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants