Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated store-devtools section of MIGRATION.md #488

Closed
wants to merge 1 commit into from
Closed

Updated store-devtools section of MIGRATION.md #488

wants to merge 1 commit into from

Conversation

glenngr
Copy link

@glenngr glenngr commented Oct 16, 2017

Updated note in @ngrx/store-devtools with updated information after fix of issue #97

Updated note in @ngrx/store-devtools with updated information after fix of issue #97
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.474% when pulling e6378e4 on glenngr:migration-guide-patch into 100a8ef on ngrx:master.

@brandonroberts
Copy link
Member

Thanks for the PR @glenngr! I would prefer this be reworded to say something like "If you're using store-devtools along with router-store, use a custom serializer" with a link to the router-store documentation.

@brandonroberts
Copy link
Member

Hey @glenngr, closing for now. Reopen if you still want to make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants