Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): fix createReducerFactory breaking initial state with meta reducers #248

Closed
wants to merge 1 commit into from

Conversation

rjokelai
Copy link
Contributor

@rjokelai rjokelai commented Aug 8, 2017

Corrects the usage of the compose method to eventually return a function that allows multiple parameters.

Closes #247

@rjokelai rjokelai force-pushed the fix-compose-method-#247 branch from 85e300a to c8aed21 Compare August 8, 2017 09:16
@rjokelai rjokelai force-pushed the fix-compose-method-#247 branch from c8aed21 to 9674b72 Compare August 8, 2017 09:17
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.452% when pulling 9674b72 on rjokelai:fix-compose-method-#247 into 84390a1 on ngrx:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.452% when pulling 9674b72 on rjokelai:fix-compose-method-#247 into 84390a1 on ngrx:master.

@rjokelai
Copy link
Contributor Author

rjokelai commented Aug 8, 2017

Hmm, seems it does not work yet correctly. Have to think this a bit still. Creating a new PR when my thoughts are clear

@rjokelai rjokelai closed this Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants