feat(Store): Added simplified API for adding meta-reducers #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
force-pushed
the
metareducer-api
branch
from
170f3c1 to
c55eff8
Compare
bfricka
reviewed
Jul 18, 2017
| metaReducers?: ActionReducer<any, any>[] | ||
| ): ActionReducerFactory<any, any> { | ||
| if (Array.isArray(metaReducers) && metaReducers.length > 0) { | ||
| return compose.apply(null, [...metaReducers, reducerFactory]); |
There was a problem hiding this comment.
No need to apply:
return compose(...metaReducers, reducerFactory)There was a problem hiding this comment.
TypeScript doesn't agree with signature, which is why I used apply:
ERROR in ngrx/platform/modules/store/src/utils.ts (92,12): Supplied parameters do not match any signature of call target.
|
I like the idea here. When writing tests, it took me a minute to realize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.