Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Devtools): Ensure Store is loaded eagerly #801

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Feb 9, 2018

Depending on the order of your NgModule or ModuleWithProvider imports, the Store could get initialized after a feature state is loaded, causing the state to be undefined when using the Devtools. This fix creates an explicit instantiation order for Store being instantiated first, so the init action is always dispatched first to initialize the state.

Closes #624, #741

@MikeRyanDev MikeRyanDev merged commit ecf1ebf into master Feb 9, 2018
@MikeRyanDev MikeRyanDev deleted the fix-devtools-state branch February 9, 2018 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store-devtools: cannot read property 'state' of undefined
2 participants