-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): Introduce @ngrx/schematics #631
Conversation
9f43d46
to
ebccc9e
Compare
ebccc9e
to
2b038f8
Compare
2b038f8
to
caa2f0e
Compare
@@ -0,0 +1,54 @@ | |||
/** | |||
* @license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this copyright declaration intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the schematics were created from examples in the Angular schematics so I wasn't sure whether to remove them all or leave them.
caa2f0e
to
b6201ae
Compare
b6201ae
to
330dc30
Compare
@brandonroberts This is a big feature for the community. It might be helpful for your sanity to get assistance. Contributors are contributors. So you can let me and the rest of us know what you need, I'm happy to help. schematics is going to be life changing for my company! cc: @zoitsa |
@peterbsmith2 I'm glad you're excited about schematics! The initial work in this PR is pretty much done pending review. What I'd like to do is get this reviewed and merged in so we can generate some nightly builds and get some people from the community to use it and provide feedback before it's published as official. If you have anything you'd specifically like to see besides what's listed in the PR, add it to #53. |
330dc30
to
d0632c8
Compare
This is looking good to me so far. Are we waiting for the tests to turn green before removing the WIP? |
I'll go ahead and remove the WIP and get the build green so we can merge it. |
d0632c8
to
92f1973
Compare
92f1973
to
e26cacf
Compare
This is ready to land @MikeRyanDev |
Awesome!!!!1 |
@brandonroberts I will want to tinker with this on nightly-builds. You can let me know the best way to get that start. I can be available for any cooperation you need. |
Implements ngrx schematics, including:
Closes #53