feat(Effects): Add root effects init action #473

timdeschryver · 2017-10-11T16:55:13Z

Closes #246

coveralls · 2017-10-11T16:58:32Z

Coverage increased (+0.9%) to 92.314% when pulling d7cd73d on tdeschryver:pr/root-effects-init into d5640ec on ngrx:master.

MikeRyanDev · 2017-10-11T17:18:50Z

modules/effects/src/effects_root_module.ts

    @Inject(ROOT_EFFECTS) rootEffects: any[],
    @Optional() storeModule: StoreModule
  ) {
    runner.start();
+    store.dispatch({ type: ROOT_EFFECTS_INIT });


I think this needs to be beneath the lines where you add the effects.

Changed.
Why exactly 😄 ?

Dispatching and registering the effects happens synchronously. Moving the dispatch to after registering the effects will give the effects a chance to listen for this new action type.

brandonroberts · 2017-10-12T01:37:19Z

modules/effects/src/effects_root_module.ts

 import { EffectsRunner } from './effects_runner';
 import { EffectSources } from './effect_sources';
 import { ROOT_EFFECTS } from './tokens';

+export const ROOT_EFFECTS_INIT = '@ngrx/store/root effects init' as '@ngrx/store/root effects init';


I would rename the type string to @ngrx/effects/init

Yep you're right, don't know what I was thinking!

coveralls · 2017-10-12T15:28:09Z

Coverage increased (+0.9%) to 92.314% when pulling a8c1419 on tdeschryver:pr/root-effects-init into d5640ec on ngrx:master.

coveralls · 2017-10-13T14:09:07Z

Coverage increased (+0.9%) to 92.314% when pulling 567d67a on tdeschryver:pr/root-effects-init into d5640ec on ngrx:master.

coveralls · 2017-10-13T14:09:57Z

Coverage increased (+0.9%) to 92.314% when pulling 567d67a on tdeschryver:pr/root-effects-init into d5640ec on ngrx:master.

MikeRyanDev · 2017-10-13T14:13:57Z

Thanks @tdeschryver!

felikf · 2017-11-13T10:53:28Z

I am just wondering ... is this supposed to work in feature effects (EffectsModule.forFeature([Effects])? Because it does not...

If I use:

@Effect({ dispatch: false }) init$= this.actions$
    .ofType(ROOT_EFFECTS_INIT)
    .do(console.log.bind(console, 'HIT!!!!'));

in root module, it works (it logs).

When I use it in feature module, it does not (it does not log).

I would need this for feature module though... :)

feat(Effects): Add root effects init action

d7cd73d

MikeRyanDev reviewed Oct 11, 2017

View reviewed changes

dispatch init after effects are added

252fb7e

brandonroberts reviewed Oct 12, 2017

View reviewed changes

rename effects init

a8c1419

brandonroberts assigned MikeRyanDev Oct 13, 2017

MikeRyanDev added 2 commits October 13, 2017 09:06

Fix small typo in "it" statement

4a52873

Remove redundant type cast

567d67a

MikeRyanDev merged commit 838ba17 into ngrx:master Oct 13, 2017

timdeschryver deleted the pr/root-effects-init branch October 13, 2017 16:44

dherges mentioned this pull request Oct 18, 2017

When will be the next relesae? Release cycles? #501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Effects): Add root effects init action #473

feat(Effects): Add root effects init action #473

timdeschryver commented Oct 11, 2017

coveralls commented Oct 11, 2017

MikeRyanDev Oct 11, 2017

timdeschryver Oct 12, 2017

MikeRyanDev Oct 13, 2017

brandonroberts Oct 12, 2017

timdeschryver Oct 12, 2017

coveralls commented Oct 12, 2017

coveralls commented Oct 13, 2017

coveralls commented Oct 13, 2017

MikeRyanDev commented Oct 13, 2017

felikf commented Nov 13, 2017 •

edited

Loading

feat(Effects): Add root effects init action #473

feat(Effects): Add root effects init action #473

Conversation

timdeschryver commented Oct 11, 2017

coveralls commented Oct 11, 2017

MikeRyanDev Oct 11, 2017

Choose a reason for hiding this comment

timdeschryver Oct 12, 2017

Choose a reason for hiding this comment

MikeRyanDev Oct 13, 2017

Choose a reason for hiding this comment

brandonroberts Oct 12, 2017

Choose a reason for hiding this comment

timdeschryver Oct 12, 2017

Choose a reason for hiding this comment

coveralls commented Oct 12, 2017

coveralls commented Oct 13, 2017

coveralls commented Oct 13, 2017

MikeRyanDev commented Oct 13, 2017

felikf commented Nov 13, 2017 • edited Loading

felikf commented Nov 13, 2017 •

edited

Loading