Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 4.4.3+, deprecated MaterialModule and changes to md-input-container #448

Closed
danielhdz56 opened this issue Oct 4, 2017 · 4 comments

Comments

@danielhdz56
Copy link
Contributor

danielhdz56 commented Oct 4, 2017

I'm submitting a...


[] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

MaterialModule has been deprecated, causing a compiling error.
Consider creating a "Material" module within their application (e.g., FooMaterialModule) that imports only the set of components actually used in the application.

Expected behavior:

No compiling error caused in:

  • core.module.ts
  • auth.module.ts,
  • app/books/components/index.ts
  • app/books/books.module.ts

Minimal reproduction of the problem with instructions:

To replace MaterialModule, users can create their own "Material" module within their application (e.g., GmailMaterialModule) that imports only the set of components actually used in the application.
https://github.com/angular/material2/blob/master/CHANGELOG.md#materialmodule

Version of affected browser(s),operating system(s), npm, node and ngrx:

Other information:

Updates on md-input-container:

  • md-input-container renamed to md-form-field
  • input: Inputs have a width of 200px by default (similar to native input elements). The width can be overridden by via the mat-form-field css class.

In book-search.ts

md-form-field {
    width: 300px;
}

instead of

input {
    width: 300px;
}
@brandonroberts
Copy link
Member

Our dependencies are currently locked, so this isn't necessarily a bug. Would accept a PR with these changes though.

@izifortune
Copy link
Contributor

I can take this one

@izifortune
Copy link
Contributor

Made some progress. All the components are updated now have to go through the unit tests

izifortune added a commit to izifortune/platform that referenced this issue Oct 14, 2017
Angular material removed the global MaterialModule all the
components needs to be imported individually.

Fixes ngrx#448
@izifortune
Copy link
Contributor

#482

izifortune added a commit to izifortune/platform that referenced this issue Oct 22, 2017
Angular material removed the global MaterialModule all the
components needs to be imported individually.

Fixes ngrx#448
izifortune added a commit to izifortune/platform that referenced this issue Oct 22, 2017
Angular material removed the global MaterialModule all the
components needs to be imported individually.

Fixes ngrx#448
krjordan pushed a commit that referenced this issue Nov 8, 2017
Angular material removed the global MaterialModule all the
components needs to be imported individually.

Fixes #448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants