Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Entity): Add support for string or number type for entity ID #441

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

brandonroberts
Copy link
Member

Closes #398

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.264% when pulling f52e88c on entity-id-types into e63720e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.413% when pulling fcee651 on entity-id-types into ad30d40 on master.

@MikeRyanDev MikeRyanDev merged commit 46d6f2f into master Oct 5, 2017
@MikeRyanDev MikeRyanDev deleted the entity-id-types branch October 5, 2017 14:59
@Lycidas0815
Copy link

Lycidas0815 commented Oct 20, 2017

Stupid question, since my project broke due to that change: how to I specify the type argument to use properly? My selectId is of type number, but I get a the type argument for type parameter Result cannot be inferred from the usage error in my reducers, using the ngrx-example app as template.

I also had a look into the entity docs but didn't find anything helpful there. The example app changed to type string, but I still want to use my numbers.

Many thanks,
Ly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants