-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngrx-store-freeze project in need of a good home, consider adoption? #393
Comments
Definitely agree with this proposal. We're looking at folding freeze and logging functionality into |
Just an update on this. The previous maintainer transferred ownership to me yesterday. I will take a look at what needs to be updated to get the package working correctly with the current version of NgRx. Then we'll look at migrating its feature set into |
@brandonroberts Great, this is wonderful to hear. Since you've now adopted it, should this issue be closed? |
Yep. I consider this issue done for now. |
[X] Feature request
The ngrx-store-freeze project is in need of a new maintainer - the original author is currently away from the Angular ecosystem:
brandonroberts/ngrx-store-freeze#17 (comment)
The “store freeze” functionality is incredibly useful for new NgRx users. store-freeze is only 13 lines of non-blank-non-comment code, perhaps the best 13 around in terms of developer experience improvement per line. It takes away the footgun aspect of immutability,in which one can very easily, accidentally have mutating data floating around in the system fundamentally designed around immutability.
Curiously, it looks like maybe this even happened to the core NgRx team, around router state, discussed in some of these: #327 #240 #104. It can happen to anyone.
Keeping all that in mind, I suggest that the NgRx team offer to adopt ngrx-store-freeze (it could become
@ngrx/store-freeze
?), keep it up-to-date with Store versions, include it in automated testing and feature planning, and so on. Of course the functionality could also be built in to Store itself, but even perhaps offering to adopt this existing project would help that user base find their way home even if something lands right in Store.The text was updated successfully, but these errors were encountered: