Nightly build for @ngrx/effects seems to be broken

[vigneshnrfs]

I've just updated my nightly build to the following commits

"@ngrx/effects@github:ngrx/effects-builds":
  version "4.0.0-alpha.0"
  resolved "https://codeload.github.com/ngrx/effects-builds/tar.gz/2487f6c2d7077c8e40ad854d57bf1ebb7737c347"

"@ngrx/store-devtools@github:ngrx/store-devtools-builds":
  version "4.0.0-alpha.0"
  resolved "https://codeload.github.com/ngrx/store-devtools-builds/tar.gz/c242ff24d168c2c0224b9be469f7e5740bf8a151"

"@ngrx/store@github:ngrx/store-builds":
  version "4.0.0-alpha.0"
  resolved "https://codeload.github.com/ngrx/store-builds/tar.gz/69367776359fcada4d22293b79ae98812180a4f4"

This is the build that removed EffectsModule.run() and added EffectsModule.forFeature()

However, my effects are only running for root module and not for feature modules.

My npm dependencies

 "devDependencies": {
    "@angular/cli": "^1.1.1",
    "@angular/compiler-cli": "^4.1.3",
    "@angular/language-service": "^4.1.3",
    "@angularclass/hmr": "^1.2.2",
    "@compodoc/compodoc": "^1.0.0-beta.9",
    "@types/jasmine": "^2.5.51",
    "@types/jszip": "^0.0.33",
    "@types/lodash": "^4.14.65",
    "@types/node": "^7.0.29",
    "codelyzer": "~3.0.1",
    "jasmine-core": "^2.6.3",
    "jasmine-spec-reporter": "~4.1.0",
    "karma": "~1.7.0",
    "karma-chrome-launcher": "~2.1.1",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^1.2.1",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.1.2",
    "ts-node": "~3.0.4",
    "tslint": "^5.4.3",
    "typescript": "~2.3.3"
  },
  "dependencies": {
    "@angular/animations": "^4.1.3",
    "@angular/common": "^4.1.3",
    "@angular/compiler": "^4.1.3",
    "@angular/core": "^4.1.3",
    "@angular/forms": "^4.1.3",
    "@angular/http": "^4.1.3",
    "@angular/platform-browser": "^4.1.3",
    "@angular/platform-browser-dynamic": "^4.1.3",
    "@angular/router": "^4.1.3",
    "@angular/service-worker": "^1.0.0-beta.15",
    "@ng-bootstrap/ng-bootstrap": "^1.0.0-alpha.25",
    "@ng2-dynamic-forms/core": "1.4.11",
    "@ng2-dynamic-forms/ui-bootstrap": "1.4.11",
    "@ngrx/effects": "github:ngrx/effects-builds",
    "@ngrx/store": "github:ngrx/store-builds",
    "@ngrx/store-devtools": "github:ngrx/store-devtools-builds",
    "angular2-text-mask": "^8.0.1",
    "angular2-uuid": "^1.1.1",
    "angulartics2": "^2.2.2",
    "autotrack": "^2.4.1",
    "aws-sdk": "^2.67.0",
    "bootstrap": "4.0.0-alpha.6",
    "class-transformer": "^0.1.6",
    "core-js": "^2.4.1",
    "font-awesome": "^4.7.0",
    "jsoneditor": "^5.5.11",
    "lodash": "^4.17.4",
    "moment": "^2.18.1",
    "ng-http-interceptor": "^3.0.1",
    "primeng": "^4.0.2",
    "reflect-metadata": "~0.1.10",
    "rxjs": "^5.2.0",
    "zone.js": "^0.8.12"
  }

[bbaia]

I found why it was failing to me: the root effects module was not the AppModule.

[vigneshnrfs]

@bbaia @brandonroberts It still does not work for me.

I have created a test repo showing the issue.

https://github.com/vigneshnrfs/ngrx_effects_test

When you run the app, you can see the the feature effect is not being logged to the console
https://github.com/vigneshnrfs/ngrx_effects_test/blob/master/src/app/feature-1/feature1.effects.ts#L11-L16

[cyr-x]

Same here, root effects are running but feature effects aren't running. My setup is like vigneshnrfs setup.

[alex-okrushko]

Any ETA on this?

[brandonroberts]

We should have a fix in for this soon. General release for V4 is targeted for July 1