Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(combineSelectors): Remove default parameter from function signatu…
…re for Closure
- Loading branch information
ae7d5e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this was ever an issue.
ae7d5e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-okrushko Do you mean this wasn't an issue when compiling NgRx apps with Closure?
ae7d5e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i don't think this was the problem. Most of Google is still on ngrx v2 and it has similar approach https://github.com/ngrx/store/blob/master/src/utils.ts#L16