Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's awesome but has memory reak problem (doesn't closing browsersubprocess) #2

Closed
MogsFriend opened this issue Jul 31, 2019 · 2 comments

Comments

@MogsFriend
Copy link

MogsFriend commented Jul 31, 2019

after i found two plugins, and find some problem.
yeah, this plugin is perfect.

@lalafellsleep has same issue, project(cefglue to cefsharp) for overlayplugin. it's like 'i need use newer chromium' and he find devtool bug ( cefsharp/CefSharp#2264 ) and fixed it.

this plugin create new browser (overlay) and close then, successfully closed but didn't closed browsersubprocess (they has avg 30mb memory)

but https://github.com/Chau-Sara/Aliapoh.Overlay not have problem.

it'll fix it?

@MogsFriend
Copy link
Author

same problem in plugin enable/disable
image
one more en/disable
image

they doesn't disposed.

@ngld
Copy link
Owner

ngld commented Aug 9, 2019

The new release (0.4.0) partially fixes the issue. The CEF processes are properly disposed and the most memory is freed. However, some memory (~ 5 MiB) still leaks when you disable the plugin. I'm not sure if I can fix this since that would involve shutting down and unloading all addons as well.

This should only affect you if you repeatedly enable and disable the plugin. If you're trying to reset / restart it, restarting ACT is a better solution since that will actually reset it (disabling the plugin doesn't do that). Even if you disable the plugin, CEF (the browser engine) stays active as long as ACT runs. If I shut down CEF, I can't use it again until the next ACT restart.

@ngld ngld closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants