Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestStatsNoStream is failing #216

Closed
lucacome opened this issue Feb 3, 2024 · 1 comment · Fixed by #224
Closed

TestStatsNoStream is failing #216

lucacome opened this issue Feb 3, 2024 · 1 comment · Fixed by #224
Labels
bug An issue reporting a potential bug
Milestone
v1.2.1

Comments

@lucacome
Copy link
Member

lucacome commented Feb 3, 2024

This test started failing after #174 but the pipeline wasn't failing on the error

test-no-stream-1  | === RUN   TestStatsNoStream
test-no-stream-1  |     client_no_stream_test.go:38: No stream block should result in StreamZoneSync = `nil`
test-no-stream-1  | --- FAIL: TestStatsNoStream (0.01s)
@lucacome
Copy link
Member Author

lucacome commented Feb 3, 2024

@dhurley @oliveromahony could you take a look?

@lucacome lucacome added the bug An issue reporting a potential bug label Feb 3, 2024
@lucacome lucacome added this to the v1.2.1 milestone Feb 3, 2024
@lucacome lucacome mentioned this issue Feb 3, 2024
Merged
@dhurley dhurley mentioned this issue Feb 8, 2024
Merged
6 tasks
@ciarams87 ciarams87 linked a pull request Feb 29, 2024 that will close this issue
Fix TestStatsNoStream #224
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Fix TestStatsNoStream dhurley/nginx-plus-go-client
2 participants
@lucacome @ciarams87