ReferenceGrant from Gateway to Secret #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
reviewed
Jun 26, 2023
sjberman
reviewed
Jun 27, 2023
pleshakov
reviewed
Jun 27, 2023
There was a problem hiding this comment.
This means we will regenerate nginx config every time a ReferenceGrant is created, updated (generation must change), or deleted, even if it does not apply to the accepted Gateway.
do we need to track these things somewhere? so that we know about them when the time comes to reduce number of reloads.
We have this issue which I think covers it: #552 |
sjberman
approved these changes
Jun 27, 2023
kate-osborn
force-pushed
the
feat/ref-grant
branch
from
f33f8f0 to
fd58b71
Compare
pleshakov
approved these changes
Jun 27, 2023
ciarams87
approved these changes
Jun 28, 2023
Co-authored-by: Saylor Berman <[email protected]>
kate-osborn
force-pushed
the
feat/ref-grant
branch
from
fd58b71 to
d7d4cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NKG does not support cross-namespace Secret references on Gateway.
Solution: Add support for ReferenceGrants that permit Gateways to reference Secrets in different namespaces. NKG now processes ReferenceGrants and verifies that Gateways with references to Secrets in different Namespaces have a corresponding ReferenceGrant. If no ReferenceGrant exists, the
RefNotPermittedreason is used in all the listener conditions (Accepted, Programmed, and ResolvedRefs), and the listener is marked invalid. Secrets will only be resolved if the reference is permitted. No additional validation is needed for ReferenceGrant as it does not correspond to any nginx config. We treat every upsert/delete of a ReferenceGrant as a change. This means we will regenerate nginx config every time a ReferenceGrant is created, updated (generation must change), or deleted, even if it does not apply to the accepted Gateway.Testing: 100% unit test coverage of new functions, updated existing unit tests, and verified that the applicable conformance test pass.
Closes #694
Checklist
Before creating a PR, run through this checklist and mark each as complete.