Add wildcard hostname support #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
kate-osborn
requested changes
Jun 21, 2023
pleshakov
reviewed
Jun 21, 2023
sjberman
force-pushed
the
feature/wildcard-hostnames
branch
from
c2a527e to
51f28e0
Compare
pleshakov
reviewed
Jun 22, 2023
Until now, users were only able to use hostnames without wildcards, limiting their options. We now support wildcard hostnames for HTTPRoutes and Gateway listeners.
kate-osborn
requested changes
Jun 22, 2023
sjberman
force-pushed
the
feature/wildcard-hostnames
branch
from
51f28e0 to
aa1e79b
Compare
pleshakov
approved these changes
Jun 22, 2023
kate-osborn
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Until now, users were only able to use hostnames without wildcards, limiting their options.
Solution: We now support wildcard hostnames for HTTPRoutes and Gateway listeners.
Testing: Added unit tests and verified nginx config manually
Closes #478