Generate default http server in NGINX if http listener exists in Gateway #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
force-pushed
the
http-listener-no-routes
branch
from
098fa92 to
bf38d61
Compare
pleshakov
reviewed
Dec 7, 2022
pleshakov
approved these changes
Dec 9, 2022
kate-osborn
force-pushed
the
http-listener-no-routes
branch
from
ed332ef to
17251e1
Compare
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: NKG does not generate an nginx server for an HTTP listener with no routes.
Fix: If an HTTP or HTTPS listener exists, we will generate an nginx default HTTP or SSL server block.
Fixes #316