Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRD manifest installation #989

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

sjberman
Copy link
Contributor

Problem: Deploying a CRD definition and an instantiation of that CRD in the same kubectl command will fail due to the kubectl cache not being updated for the existence of the CRD definition. They need to be run in separate commands.
Solution: Separate the CRDs into a different file and install prior to installing the rest of the gateway resources.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner August 17, 2023 22:10
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Aug 17, 2023
Problem: Deploying a CRD definition and an instantiation of that CRD in the same kubectl command will fail due to the kubectl cache not being updated for the existence of the CRD definition. They need to be run in separate commands.
Solution: Separate the CRDs into a different file and install prior to installing the rest of the gateway resources.
@sjberman sjberman force-pushed the chore/fix-crds-manifest branch from bb31ffe to ca165d9 Compare August 17, 2023 22:24
@sjberman sjberman enabled auto-merge (squash) August 18, 2023 14:19
@sjberman sjberman merged commit 9cc25a3 into nginxinc:main Aug 18, 2023
@sjberman sjberman deleted the chore/fix-crds-manifest branch August 18, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants