-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a guide about upgrading applications without downtime #944
Add a guide about upgrading applications without downtime #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also tag someone from the docs team and PM to do a review of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great doc! Just a couple small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Problem: As a user of NKG, I want a guide to explain the different strategies I can upgrade my application (NOT NKG) while using NKG specific features (such as traffic splitting) So that I minimize the downtime my application encounters. Solution: - Add a guide that covers NKG specific features that help upgrade applications without downtime - Introduce a new /docs/guide folder for guides. - Add a link to the guides folder from the main README. Testing: none Closes nginxinc#704 Co-authored-by: Saylor Berman <[email protected]> Co-authored-by: Kate Osborn <[email protected]>
5915410
to
499ca56
Compare
This commit changes the order of content in the upgrade guide, as well as rewriting much of the text to be more concise. Some of the footnote-style links have also been changed to be inline ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed a large amount of changes to the document which restructure the text and rephrase much of the content. Most of the changes were for the sake of imperative instructions and removing various qualifiers, making the text more concise.
Some of these changes, however, do not pass due to the Markdown line length checker. What convention is that specific length based on?
There are many instances of links written in a footnote notation style which is unprecedented elsewhere in NGINX; most of them could be written with regular inline markdown links.
I can push additional changes to fix the Markdown checks but they would be prioritising passing the check as opposed to the readability. You might find it useful to check out the "Content Types and Templates" internal page for an example of the information architecture used elsewhere for future docs.
👍
the length limit is 80. We choose it for all markdown files in our repo, so that is is easier read the source file and to review. I made a few changes based on your changes. Mainly:
Please let me know if those are ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one minor suggestion - "Upstream Servers Updates" => "Upstream Server Updates". Updates is already pluralised and making Server singular is better for readability, with the possibility of multiple implied in context.
If the plan at a later stage is to serve the docs through a website, the markdown line length checking may become an issue since the line length is currently prioritising GitHub readability.
IDEs and web frameworks have no issue with word wrapping paragraphs of arbitrary line length, so this may become the writing equivalent of technical debt that'll need to be addressed if the default expectation of reader consumption through GitHub changes.
Co-authored-by: Alan Dooley <[email protected]>
Proposed changes
Problem:
As a user of NKG, I want a guide to explain the different strategies I can upgrade my application (NOT NKG) while using NKG specific features (such as traffic splitting) So that I minimize the downtime my application encounters.
Solution:
Testing: none
Closes #704
Checklist
Before creating a PR, run through this checklist and mark each as complete.