Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The yaml files in the repo were not linted.
Solution: Add yamllint step to pre-commit and as a CI step. All yaml files except the helm template files will be linted before every commit (with some rules excepted for the .github workflow files, any yaml files that include raw NGINX config, and line length in the deployment yaml). Linting rules are in the
.yamllint.yaml
file in the root of the repo. For details on the linting rules, see: https://yamllint.readthedocs.io/en/stable/rules.html#Testing: Verified yaml files are linted on pre-commit.
Closes #539
Checklist
Before creating a PR, run through this checklist and mark each as complete.