Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local build #889

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix local build #889

merged 2 commits into from
Jul 19, 2023

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Jul 19, 2023 •
edited
Loading

Proposed changes

Problem:

c52b4da renamed the local build folder.
However, the renaming in the Dockerfile wasn't done so the local building of NKG using local go env become broken.

Solution:
Fix the Dockerfile

Tests:
Manually run make container

Note: needs #888 for successfull testing

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pleshakov
Fix local build
aa3ac50 
Problem:

c52b4da renamed the local build folder.
Gowever, the renaming in the Dockerfile wasn't done so
the local building of NKG using local go env become broken.

Solution:
Fix the Dockerfile

Tests:
Manually run `make container`
@pleshakov pleshakov requested a review from a team as a code owner July 19, 2023 21:51
@github-actions github-actions bot added the bug Something isn't working label Jul 19, 2023
@pleshakov pleshakov merged commit 7b06993 into nginx:main Jul 19, 2023
@pleshakov pleshakov deleted the fix/local-build branch July 19, 2023 22:14
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Fix local build (nginx#889)
cea7737 
Problem:

c52b4da renamed the local build folder.
However, the renaming in the Dockerfile wasn't done so
the local building of NKG using local go env become broken.

Solution:
Fix the Dockerfile

Tests:
Manually run `make container`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @sjberman @kate-osborn