-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cross-namespace BackendRefs in HTTPRoutes #806
Merged
kate-osborn
merged 9 commits into
nginxinc:main
from
kate-osborn:feat/ref-grant-backends
Jul 6, 2023
Merged
Support cross-namespace BackendRefs in HTTPRoutes #806
kate-osborn
merged 9 commits into
nginxinc:main
from
kate-osborn:feat/ref-grant-backends
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Jun 30, 2023
sjberman
reviewed
Jun 30, 2023
ciarams87
reviewed
Jul 3, 2023
pleshakov
reviewed
Jul 5, 2023
Suggestion: since the PR name will end up in the changelog, perhaps "Support ReferenceGrants for allowing cross-namespace BackendRefs in HTTPRoutes" or simply " Support cross-namespace BackendRefs in HTTPRoutes" can better reflect the PR from the user perspective? |
kate-osborn
changed the title
ReferenceGrant from HTTPRoute to BackendObjectReference
Support cross-namespace BackendRefs in HTTPRoutes
Jul 5, 2023
sjberman
approved these changes
Jul 5, 2023
ciarams87
approved these changes
Jul 6, 2023
pleshakov
approved these changes
Jul 6, 2023
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Ciara Stacke <[email protected]>
Co-authored-by: Michael Pleshakov <[email protected]>
kate-osborn
force-pushed
the
feat/ref-grant-backends
branch
from
July 6, 2023 18:24
83f5354
to
7d20e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow HTTPRoutes to reference Backends in different namespaces if a ReferenceGrant permits it.
Problem: NKG does not allow HTTPRoutes to reference Backends in different namespaces.
Solution: Allow HTTPRoutes to reference Backends in different namespaces if a ReferenceGrant permits it. Both SecretObjectReferences and BackendObjectReferences are resolved through the referenceGrantResolver. The referenceGrantResolver transforms the map of ReferenceGrants into a structure that allows for O(n) lookup of references.
Testing: Added & modified unit tests. Made sure all ReferenceGrant conformance tests passed, including the new
HTTPRouteInvalidReferenceGrant
test.Closes #695
Checklist
Before creating a PR, run through this checklist and mark each as complete.