Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GatewayClass status for ignored GatewayClasses #804

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

sjberman
Copy link
Contributor

Problem: It is expected that any GatewayClass that references our controller should have its status set properly, even if not used by our controller.

Solution: Both the provisioner and controller will now add Accepted status False and ObservedGeneration to any GatewayClass that references our controller but is not configured to be used by our controller.

Testing: Conformance test now passes. Controller will also properly set statuses when not using provisioner.

Closes #775

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner June 29, 2023 20:13
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Jun 29, 2023
@sjberman sjberman requested a review from kate-osborn June 29, 2023 22:03
sjberman added 3 commits June 30, 2023 08:44
Problem: It is expected that any GatewayClass that references our controller should have its status set properly, even if not used by our controller.

Solution: Both the provisioner and controller will now add Accepted status False and ObservedGeneration to any GatewayClass that references our controller but is not configured to be used by our controller.
@sjberman sjberman force-pushed the bug/gateway-class-status branch from a6d942a to 9c677a9 Compare June 30, 2023 16:56
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pleshakov let me know what you think of the change I pushed to handle this. Basically we delete the GC if the controller name doesn't equal our name. I know you're messing around with the code I altered, so not sure if there's a better solution for it.

internal/events/handler.go Outdated Show resolved Hide resolved
internal/manager/predicate/gatewayclass.go Show resolved Hide resolved
@sjberman sjberman force-pushed the bug/gateway-class-status branch from 3bf7370 to e8d9463 Compare June 30, 2023 18:00
@sjberman sjberman requested a review from pleshakov June 30, 2023 19:41
@sjberman sjberman merged commit f049a86 into nginxinc:main Jun 30, 2023
@sjberman sjberman deleted the bug/gateway-class-status branch June 30, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Set Accepted condition and bump observed gen for all GatewayClasses with our controller name
3 participants