Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer guide to CONTRIBUTING.md #669

Merged
merged 22 commits into from
May 30, 2023
Merged

Add developer guide to CONTRIBUTING.md #669

merged 22 commits into from
May 30, 2023

Conversation

kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented May 23, 2023 •
edited
Loading

Adds the following developer docs:

  • Quickstart
  • Branching and Workflow
  • Implement a Feature
  • Testing
  • Pull Request Guidelines

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Closes #670

@kate-osborn kate-osborn requested a review from a team as a code owner May 23, 2023 20:30
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels May 23, 2023
pleshakov
pleshakov suggested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff overall 👍

@kate-osborn kate-osborn requested a review from pleshakov May 23, 2023 22:35
sjberman
sjberman reviewed May 24, 2023
View reviewed changes
@kate-osborn kate-osborn mentioned this pull request May 24, 2023
Merged
6 tasks
@kate-osborn kate-osborn removed the chore Pull requests for routine tasks label May 24, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 25, 2023
@kate-osborn kate-osborn requested review from pleshakov and sjberman May 25, 2023 16:56
@kate-osborn kate-osborn mentioned this pull request May 25, 2023
Merged
6 tasks
pleshakov
pleshakov approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kate-osborn kate-osborn force-pushed the chore/developer-guide branch from 9bb08fc to dc676d6 Compare May 30, 2023 20:35
@kate-osborn kate-osborn merged commit 5fbfb7c into nginx:main May 30, 2023
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
@miledxz
Add developer guide to CONTRIBUTING.md (nginx#669)
7991bb1 
Adds the following developer docs:
- Quickstart
- Branching and Workflow
- Implement a Feature
- Testing
- Pull Request Guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add developer guide to CONTRIBUTING.md
4 participants
@kate-osborn @pleshakov @sjberman @ciarams87