Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NKG-specific field validation for Gateways #407

Merged
merged 9 commits into from
Feb 9, 2023
Merged

Implement NKG-specific field validation for Gateways #407

merged 9 commits into from
Feb 9, 2023

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Fixes #406

@pleshakov
Transform RouteCondition into general Condition
1267e38 
This will allow use the type for Gateway and other resources, not just
HTTPRoute
@pleshakov
Implement NKG-specific field validation for Gateway resource
17fce88 
Fixes #406
@pleshakov pleshakov requested a review from a team as a code owner February 2, 2023 23:07
@github-actions github-actions bot added the enhancement New feature or request label Feb 2, 2023
@pleshakov pleshakov requested a review from kate-osborn February 2, 2023 23:13
kate-osborn
kate-osborn requested changes Feb 6, 2023
View reviewed changes
internal/state/conditions/conditions_test.go Outdated Show resolved Hide resolved
internal/state/graph_test.go Show resolved Hide resolved
internal/state/listener.go Outdated Show resolved Hide resolved
internal/state/listener.go Outdated Show resolved Hide resolved
internal/state/listener.go Outdated Show resolved Hide resolved
internal/state/listener.go Outdated Show resolved Hide resolved
internal/state/statuses.go Show resolved Hide resolved
internal/state/statuses_test.go Show resolved Hide resolved
internal/status/conditions_test.go Show resolved Hide resolved
internal/state/statuses.go Show resolved Hide resolved
@pleshakov pleshakov requested a review from kate-osborn February 8, 2023 00:09
kate-osborn
kate-osborn requested changes Feb 8, 2023
View reviewed changes
internal/state/listener.go Outdated Show resolved Hide resolved
internal/state/listener.go Show resolved Hide resolved
internal/state/listener.go Show resolved Hide resolved
@pleshakov pleshakov requested a review from kate-osborn February 8, 2023 18:57
@pleshakov pleshakov merged commit e4b6446 into main Feb 9, 2023
@pleshakov pleshakov deleted the feature/nkg-validation-gateway branch February 9, 2023 00:39
@pleshakov pleshakov mentioned this pull request Mar 7, 2023
Merged
@pleshakov pleshakov changed the title Implement NKG-specific field validation for Gateway resource Implement NKG-specific field validation for Gateways Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement NKG-specific field validation for Gateway resource
2 participants
@pleshakov @kate-osborn