Run webhook validation rules inside NKG control plane #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
That comes from which is to generate a unique name in case multiple NKGs are in the cluster. But it looks for sure confusing. Perhaps |
kate-osborn
requested changes
Jan 19, 2023
Hmm. Let's just keep it as it is for now. |
kate-osborn
requested changes
Jan 24, 2023
kate-osborn
approved these changes
Jan 24, 2023
In case the webhook is not installed or not running validation properly, we still want NKG to ensure that the webhook validation is always performed and NKG rejects any invalid resource. Fixes #362
pleshakov
force-pushed
the
feature/webhook-validation
branch
from
d14c065 to
c96415f
Compare
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In case the webhook is not installed or not running validation properly, we still want NKG to ensure that the webhook validation is always performed and NKG rejects any invalid resource.
Fixes #362
Example of an event for an invalid HTTPRoute:
Example of a error log messages for the same HTTPRoute:
{"level":"error","ts":"2023-01-19T19:08:19Z","msg":"Rejected the resource because the Gateway API webhook failed to reject it with a validation error; make sure the webhook is installed and running correctly","controller":"httproute","controllerGroup":"gateway.networking.k8s.io","controllerKind":"HTTPRoute","HTTPRoute":{"name":"coffee","namespace":"default"},"namespace":"default","name":"coffee","reconcileID":"3be665e7-3ced-40bc-9a89-91a41182fd50","error":"spec.rules[0].matches[0].path.value: Invalid value: \"//coffee\": must not contain \"//\"","errorCauses":[{"error":"spec.rules[0].matches[0].path.value: Invalid value: \"//coffee\": must not contain \"//\""}],"stacktrace":"github.com/nginxinc/nginx-kubernetes-gateway/internal/reconciler.(*Implementation).Reconcile\n\tgithub.com/nginxinc/nginx-kubernetes-gateway/internal/reconciler/implementation.go:115\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235"}