Always generate a root "/" location block in NGINX config to handle unmatched requests with 404 response

[kate-osborn]

If no root path ("/") is defined by the user for a server, generate a location block for the root path that returns 404.

[pleshakov]

👍

[pleshakov]

A rule like below

  - matches:
    - path:
        type: PathPrefix
        value: " /"

leads to

        location  / {

              . . .



        }

        location / {



                return 404 ;





        }

and NGINX failing to reload:

2023/01/10 22:59:31 [emerg] 40#40: duplicate location "/" in /etc/nginx/conf.d/http.conf:63

I think that should be covered by the validation in #343

What do you think?

[kate-osborn]

A rule like below

  - matches:
    - path:
        type: PathPrefix
        value: " /"

leads to

        location  / {

              . . .



        }

        location / {



                return 404 ;





        }

and NGINX failing to reload:

2023/01/10 22:59:31 [emerg] 40#40: duplicate location "/" in /etc/nginx/conf.d/http.conf:63

I think that should be covered by the validation in #343

What do you think?

That shouldn't happen with these changes. I verified that only one root location per server block will ever be generated.

(Edit): I missed the leading space in the path. Yeah, I think that case is covered by the validation work.