Support NoMatchingListenerHostname reason in HTTPRoute status #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
force-pushed
the
feature/httproute-status-NoMatchingListenerHostname-reason
branch
from
4281a36 to
a26e3ca
Compare
|
@pleshakov does the compatibility doc need to be updated to reflect these changes? |
kate-osborn
requested changes
Nov 3, 2022
|
not resolving the conflicts yet -- those conflicts are because of the recent line-length changes. I will resolve them before merging so that the review-related changes to the PR are only about the PR comments. |
github-actions
bot
added
the
documentation
kate-osborn
requested changes
Nov 7, 2022
kate-osborn
approved these changes
Nov 7, 2022
pleshakov
force-pushed
the
feature/httproute-status-NoMatchingListenerHostname-reason
branch
2 times, most recently
from
b31a452 to
00dccce
Compare
If an HTTPRoute references a listener with the hostname that does not match any hostnames of the HTTPRoute, NGINX Kubernetes Gateway will set the condition "Accepted" with the status "False" and the reason "NoMatchingListenerHostname" in the status of the HTTPRoute. The commit introduces a new type RouteCondition. It is used to capture status-related conditions when building the graph. It will be used to capture other conditions too, including when building configuration. Note: the implementation required implementing a few additional conditions. In one case, to wait until the corresponding reasons (v1beta1.RouteConditionReason) are added to the Gateway API and in the other case, to not increase the scope, those conditions are left to be implemented (FIXMEs).
pleshakov
force-pushed
the
feature/httproute-status-NoMatchingListenerHostname-reason
branch
from
00dccce to
4c82cc0
Compare
f5yacobucci
reviewed
Nov 15, 2022
f5yacobucci
reviewed
Nov 15, 2022
f5yacobucci
reviewed
Nov 16, 2022
f5yacobucci
reviewed
Nov 16, 2022
f5yacobucci
reviewed
Nov 16, 2022
f5yacobucci
approved these changes
Dec 5, 2022
pleshakov
deleted the
feature/httproute-status-NoMatchingListenerHostname-reason
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If an HTTPRoute references a listener with the hostname that does not match any hostnames of the HTTPRoute, NGINX Kubernetes Gateway will set the condition "Accepted" with the status "False" and the reason "NoMatchingListenerHostname" in the status of the HTTPRoute.
The commit introduces a new type RouteCondition. It is used to capture status-related conditions when building the graph. It will be used to capture other conditions too, including when building configuration.
Note: the implementation required implementing a few additional conditions. In one case, to wait until the corresponding reasons (v1beta1.RouteConditionReason) are added to the Gateway API and in the other case, to not increase the scope, those conditions are left to be implemented (FIXMEs).