Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadbalancerIP as a helm parameter #2766

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Nov 11, 2024

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users want to specify load balancer IP when doing a helm install or upgrade.

Solution: Add a parameter loadBalancerIP under service in values.yaml.

Testing: Manual testing with specifying loadBalancerIP when doing a helm install and verify if svc NGF has the correct value

helm install ngf charts/nginx-gateway-fabric --values ./charts/nginx-gateway-fabric/values.yaml  --create-namespace -n nginx-gateway  --set nginxGateway.image.repository=nginx-gateway-fabric --set nginxGateway.image.tag=$(whoami) --set nginxGateway.image.pullPolicy=Never --set nginx.image.repository=nginx-gateway-fabric/nginx --set nginx.image.tag=$(whoami) --set nginx.image.pullPolicy=Never --set service.loadBalancerIP=127.0.0.1
NAME: ngf
LAST DEPLOYED: Mon Nov 11 09:55:59 2024
NAMESPACE: nginx-gateway
STATUS: deployed
REVISION: 1
TEST SUITE: None
k describe service -n nginx-gateway ngf-nginx-gateway-fabric
Name:                     ngf-nginx-gateway-fabric
Namespace:                nginx-gateway
Labels:                   app.kubernetes.io/instance=ngf
                          app.kubernetes.io/managed-by=Helm
                          app.kubernetes.io/name=nginx-gateway-fabric
                          app.kubernetes.io/version=edge
                          helm.sh/chart=nginx-gateway-fabric-1.4.0
Annotations:              meta.helm.sh/release-name: ngf
                          meta.helm.sh/release-namespace: nginx-gateway
Selector:                 app.kubernetes.io/instance=ngf,app.kubernetes.io/name=nginx-gateway-fabric
Type:                     LoadBalancer
IP Family Policy:         SingleStack
IP Families:              IPv4
IP:                       10.96.252.162
IPs:                      10.96.252.162
IP:                       127.0.0.1
Port:                     http  80/TCP
TargetPort:               80/TCP
NodePort:                 http  31124/TCP
Endpoints:                10.244.0.5:80
Port:                     https  443/TCP
TargetPort:               443/TCP
NodePort:                 https  32155/TCP
Endpoints:                10.244.0.5:443
Session Affinity:         None
External Traffic Policy:  Local
HealthCheck NodePort:     32444
Events:                   <none>

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #2290

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Adds `loadBalancerIP` as a helm parameter to use during install/upgrade.

@salonichf5 salonichf5 requested a review from a team as a code owner November 11, 2024 18:07
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (77be35b) to head (ea5a31b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2766   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files         110      110           
  Lines       10913    10913           
  Branches       50       50           
=======================================
  Hits         9757     9757           
  Misses       1098     1098           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman removed the enhancement New feature or request label Nov 12, 2024
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the enhancement New feature or request label Nov 12, 2024
@salonichf5 salonichf5 enabled auto-merge (squash) November 12, 2024 17:05
@sjberman sjberman removed the enhancement New feature or request label Nov 12, 2024
@salonichf5 salonichf5 merged commit a48a1ea into nginx:main Nov 12, 2024
47 checks passed
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Add loadbalancerIP as helm parameter

Problem: Users want to specify load balancer IP when doing a helm install or upgrade.

Solution: Add a parameter loadBalancerIP under service in values.yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow user to specify LoadBalancerIP for Service in helm chart
3 participants