-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backend group name with a prefix #2730
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
+ Coverage 89.38% 89.40% +0.01%
==========================================
Files 110 110
Lines 10913 10913
Branches 50 50
==========================================
+ Hits 9755 9757 +2
+ Misses 1100 1098 -2
Partials 58 58 ☔ View full report in Codecov by Sentry. |
087b35c
to
1c477e4
Compare
✅ Deploy Preview will be available once build job completes!
|
893cbd2
to
ad3e324
Compare
ad3e324
to
3565083
Compare
00dc128
to
80e3e14
Compare
80e3e14
to
bf5b14b
Compare
site/content/how-to/traffic-management/routing-traffic-to-your-app.md
Outdated
Show resolved
Hide resolved
Be sure to use your fork in the future, this doesn't need to be a branch on the main repo. |
22e0514
to
781816f
Compare
Thank you for noticing that ! Need to fix my setup, probably messed it up ! |
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: User want to configure split client upstream in a namespace starting with a digit without running into any issues.
When a user was configuring split clients in a namespace starting with a digit, it led to
proxy_pass
variable beinghttp://$9c_network__some_route_name_rule0$request_uri
, which led to issues with nginx since variable names cannot start with a digit, leading to a 502 Bad Gateway error. The above problem existed for cases when a variable name is mentioned for using split weightage of upstreams.Solution: Updated backend group name with a prefix "group_". Hence, we update split client variable names, distribution names and upstream names.
Testing: Testing with cafe and traffic splitting example.
Config with cafe example
Config with trafic-splitting example
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2606
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.