Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower upstream count for scale nfr test with nginx plus #2695

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Oct 16, 2024

Problem: We were running into infrequent test failures due to nginx plus running out of memory when scaling upstreams.

Solution: Lower the upstream count when running with nginx plus by 2% of the previous maximum. Also, ran into an issue where the test had an incorrect WithTimeout check which caused an assertion to incorrectly only run once. Will monitor future NFR runs to see if this issue persists.

Testing: Ran the nfr scale test and it passed.

Closes #2563

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@bjee19 bjee19 requested a review from a team as a code owner October 16, 2024 21:32
@github-actions github-actions bot added the tests Pull requests that update tests label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (0a4f0fb) to head (1a13b42).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2695   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         110      110           
  Lines        8615     8615           
  Branches       50       50           
=======================================
  Hits         7665     7665           
  Misses        892      892           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2024
@bjee19 bjee19 force-pushed the tests/fix-scale-upstreams-nginx-plus branch from 0bc4dd3 to 1a13b42 Compare October 16, 2024 22:21
@bjee19 bjee19 merged commit f2da836 into nginxinc:main Oct 16, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NFR Scale upstreams tests continue to report out of memory errors
3 participants