Lower upstream count for scale nfr test with nginx plus #2695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We were running into infrequent test failures due to nginx plus running out of memory when scaling upstreams.
Solution: Lower the upstream count when running with nginx plus by 2% of the previous maximum. Also, ran into an issue where the test had an incorrect
WithTimeout
check which caused an assertion to incorrectly only run once. Will monitor future NFR runs to see if this issue persists.Testing: Ran the nfr scale test and it passed.
Closes #2563
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.