Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support.md #2693

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Update support.md #2693

merged 5 commits into from
Oct 24, 2024

Conversation

mpstefan
Copy link
Collaborator

Adding an explicit line about dedicated support

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format: Adding an explicit line about dedicated support

Problem: Documentation needs to be updated

Solution: Changing the documentation

Testing: I read the documentation

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Adding an explicit line about dedicated support
@mpstefan mpstefan requested review from a team as code owners October 16, 2024 15:55
Copy link
Contributor

github-actions bot commented Oct 16, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2024
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-gateway-fabric/2693/

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (105a5e3) to head (035ac23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         110      110           
  Lines       10913    10913           
  Branches       50       50           
=======================================
  Hits         9755     9755           
  Misses       1100     1100           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have some edit suggestions.

site/content/support.md Outdated Show resolved Hide resolved
@sjberman sjberman enabled auto-merge (squash) October 24, 2024 16:08
@mpstefan
Copy link
Collaborator Author

I have hereby read the F5 CLA and agree to its terms

Whitespace
@sjberman sjberman merged commit 0c66069 into main Oct 24, 2024
43 checks passed
@sjberman sjberman deleted the support-update branch October 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants