Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unchecked type assertions #2580

Merged
merged 5 commits into from
Sep 24, 2024

Merge branch 'main' into chore/fix-assertion

ee2070b
Select commit
Loading
Failed to load commit list.
Merged

Fix unchecked type assertions #2580

Merge branch 'main' into chore/fix-assertion
ee2070b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 0s

89.20% (-6.00%) compared to dc3a925

View this Pull Request on Codecov

89.20% (-6.00%) compared to dc3a925

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (dc3a925) to head (ee2070b).

Files with missing lines Patch % Lines
internal/mode/static/manager.go 0.00% 8 Missing ⚠️
internal/framework/status/updater.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
- Coverage   95.19%   89.20%   -6.00%     
==========================================
  Files           1      100      +99     
  Lines         229     7642    +7413     
  Branches       50       50              
==========================================
+ Hits          218     6817    +6599     
- Misses         11      768     +757     
- Partials        0       57      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.