-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unchecked type assertions #2580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a helper function that we use for type assertions: https://github.com/nginxinc/nginx-gateway-fabric/blob/9971881bf2a8afb746a0105e365ed71d4f8724df/internal/framework/helpers/helpers.go#L49C6-L49C20
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
==========================================
- Coverage 95.19% 89.20% -6.00%
==========================================
Files 1 100 +99
Lines 229 7642 +7413
Branches 50 50
==========================================
+ Hits 218 6817 +6599
- Misses 11 768 +757
- Partials 0 57 +57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except for the missing unit tests
5cfb1d7
to
9445586
Compare
Proposed changes
Fixes the remaining unchecked type assertions
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.