Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm schema #2492

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add Helm schema #2492

merged 1 commit into from
Sep 30, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: Deploying the chart with wrong values could result in an incorrectly configured NGF

Solution: Enforce the values with a schema.json

Closes #2156

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Add schema for the Helm Chart

@lucacome lucacome requested a review from a team as a code owner August 30, 2024 19:11
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (4397050) to head (f96dfbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2492   +/-   ##
=======================================
  Coverage   88.61%   88.61%           
=======================================
  Files         105      105           
  Lines        8110     8110           
  Branches       50       50           
=======================================
  Hits         7187     7187           
  Misses        866      866           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

charts/nginx-gateway-fabric/values.yaml Outdated Show resolved Hide resolved
charts/nginx-gateway-fabric/values.yaml Outdated Show resolved Hide resolved
charts/nginx-gateway-fabric/values.yaml Outdated Show resolved Hide resolved
charts/nginx-gateway-fabric/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@lucacome
Copy link
Member Author

lucacome commented Sep 5, 2024

I have hereby read the F5 CLA and agree to its terms

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Sep 20, 2024
@github-actions github-actions bot added tests Pull requests that update tests and removed stale Pull requests/issues with no activity labels Sep 23, 2024
Problem: Deploying the chart with wrong values could result in an
incorrectly configured NGF

Solution: Enforce the values with a schema.json
@lucacome lucacome enabled auto-merge (squash) September 30, 2024 20:23
@lucacome lucacome merged commit d6a478d into nginxinc:main Sep 30, 2024
45 checks passed
@lucacome lucacome deleted the helm/schema branch September 30, 2024 21:35
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
Problem: Deploying the chart with wrong values could result in an
incorrectly configured NGF

Solution: Enforce the values with a schema.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Helm Schema
5 participants